[webkit-reviews] review denied: [Bug 69481] The GTK+ WebKit2 headers produce a lot of style warnings : [Attachment 109886] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 6 14:21:51 PDT 2011
David Levin <levin at chromium.org> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 69481: The GTK+ WebKit2 headers produce a lot of style warnings
https://bugs.webkit.org/show_bug.cgi?id=69481
Attachment 109886: Patch
https://bugs.webkit.org/attachment.cgi?id=109886&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109886&action=review
Just one comment beyond what Daniel said (whose comments I agree with). Thanks
Daniel!
> Tools/Scripts/webkitpy/style/checker.py:285
> +
re.compile('Source/WebKit2/UIProcess/API/gtk/WebKit(?!.*Private.h).*.h$'),
Should be:
re.compile(r'Source/WebKit2/UIProcess/API/gtk/WebKit(?!.*Private\.h).*\.h$'),
More information about the webkit-reviews
mailing list