[webkit-reviews] review requested: [Bug 69541] [Qt][WK2] ApplicationCache LayoutTests failed : [Attachment 109978] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 6 11:42:58 PDT 2011
Alexis Menard <alexis.menard at openbossa.org> has asked for review:
Bug 69541: [Qt][WK2] ApplicationCache LayoutTests failed
https://bugs.webkit.org/show_bug.cgi?id=69541
Attachment 109978: patch
https://bugs.webkit.org/attachment.cgi?id=109978&action=review
------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109978&action=review
> Source/WebKit2/UIProcess/qt/WebContextQt.cpp:39
> + return
QDesktopServices::storageLocation(QDesktopServices::DataLocation);
I don't think this is the right fix because you don't want to call
QDesktopServices every single time.
Also this file changed have a look at http://trac.webkit.org/changeset/96702 to
use the same pattern as the other.
More information about the webkit-reviews
mailing list