[webkit-reviews] review denied: [Bug 69503] CSS text-transform should apply to select elements : [Attachment 109920] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 6 11:39:42 PDT 2011

Tony Chang <tony at chromium.org> has denied Ben Wells <benwells at chromium.org>'s
request for review:
Bug 69503: CSS text-transform should apply to select elements

Attachment 109920: Patch

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109920&action=review

> Source/WebCore/rendering/style/RenderStyle.h:525
> +    void applyTextTransform(String& text, UChar previousCharacter) const;

RenderStyle is the wrong place for this function.  I would keep it in
RenderText.h and either make it static (pass in texttransform value) or just
make it a global function like toRenderText.

More information about the webkit-reviews mailing list