[webkit-reviews] review granted: [Bug 69450] [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled. : [Attachment 109833] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 69450: [EFL] DRT: Create icon database path in
LayoutTestController::setIconDatabaseEnabled.
https://bugs.webkit.org/show_bug.cgi?id=69450

Attachment 109833: Patch
https://bugs.webkit.org/attachment.cgi?id=109833&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109833&action=review


It'll be nice if the logic to obtain the temp dir. was extracted as a function.


> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:403
> +    char* tempDir = getenv("TMPDIR");

You should use const char* instead.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:409
> +    else {
> +	   tempDir = getenv("TEMP");
> +	   if (tempDir)

You should define the variable inside if as in:
else if (tempDir = getenv("TEMP"))