[webkit-reviews] review denied: [Bug 69441] [chromium] Keep track of the paint rect in layers : [Attachment 109982] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 69441: [chromium] Keep track of the paint rect in layers
https://bugs.webkit.org/show_bug.cgi?id=69441

Attachment 109982: Patch
https://bugs.webkit.org/attachment.cgi?id=109982&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109982&action=review


I think that this should be the return value of whatever function is
calculating it and not state on the layer.

> Source/WebCore/platform/graphics/chromium/LayerChromium.h:218
> +    FloatRect m_actuallyRepaintedRect;

This isn't really state on the layer, is it? Isn't it an output from
updateCompositorResources()?

Also I'm a bit confused about the name - if this is about repainting, why isn't
it calculated by paintContentsIfDirty()? It sounds more like this is talking
about the portion of the layer that was changed due to texture uploads and the
like, which isn't necessarily the same thing as the portion that was painted.