[webkit-reviews] review denied: [Bug 69541] [Qt][WK2] ApplicationCache LayoutTests failed : [Attachment 109978] patch

[bugzilla-daemon at webkit.org]

Chang Shu <cshu at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s request for
review:
Bug 69541: [Qt][WK2] ApplicationCache LayoutTests failed
https://bugs.webkit.org/show_bug.cgi?id=69541

Attachment 109978: patch
https://bugs.webkit.org/attachment.cgi?id=109978&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109978&action=review


> Source/WebKit2/ChangeLog:9
> +	   set and we didn't set yet.

Shall we set the applicationCacheDirectory somewhere like WK1 does? What if the
UI client indeed sets the cacheDirectory and this code change will break it.

> Source/WebKit2/UIProcess/qt/WebContextQt.cpp:39
> +    return
QDesktopServices::storageLocation(QDesktopServices::DataLocation);

Even if the approach is correct, I think we should call the existing function
defaultDataLocation() in the same file instead.