[webkit-reviews] review denied: [Bug 69541] [Qt][WK2] ApplicationCache LayoutTests failed : [Attachment 109978] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 6 11:16:23 PDT 2011

Chang Shu <cshu at webkit.org> has denied qi <qi.2.zhang at nokia.com>'s request for
Bug 69541: [Qt][WK2] ApplicationCache LayoutTests failed

Attachment 109978: patch

------- Additional Comments from Chang Shu <cshu at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109978&action=review

> Source/WebKit2/ChangeLog:9
> +	   set and we didn't set yet.

Shall we set the applicationCacheDirectory somewhere like WK1 does? What if the
UI client indeed sets the cacheDirectory and this code change will break it.

> Source/WebKit2/UIProcess/qt/WebContextQt.cpp:39
> +    return

Even if the approach is correct, I think we should call the existing function
defaultDataLocation() in the same file instead.

More information about the webkit-reviews mailing list