[webkit-reviews] review denied: [Bug 64071] new-run-webkit-tests does not support qt-4.8 results : [Attachment 109960] proposed fix

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 64071: new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Attachment 109960: proposed fix
https://bugs.webkit.org/attachment.cgi?id=109960&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109960&action=review


I tested your patch, but I found one more thing. Skipped 
file in qt-<version> directory is ignored, but we need it.

Could you override _skipped_file_search_paths too?

> Tools/Scripts/webkitpy/layout_tests/port/qt.py:93
> +    def qt_version(self):

@memoized is still missing :-/