[webkit-reviews] review granted: [Bug 69506] [GTK] Do not use C API in GTK+ API public headers : [Attachment 109932] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted  review:
Bug 69506: [GTK] Do not use C API in GTK+ API public headers
https://bugs.webkit.org/show_bug.cgi?id=69506

Attachment 109932: Patch
https://bugs.webkit.org/attachment.cgi?id=109932&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109932&action=review


Okay...I think I'm convinced.

> Source/WebKit2/UIProcess/API/gtk/WebKitDefines.h:45
> +#include <glib.h>
> +
> +#ifdef G_OS_WIN32
> +#	ifdef BUILDING_WEBKIT
> +#	    define WEBKIT_API __declspec(dllexport)
> +#	else
> +#	    define WEBKIT_API __declspec(dllimport)
> +#	endif
> +#	define WEBKIT_OBSOLETE_API WEBKIT_API
> +#else
> +#	define WEBKIT_API __attribute__((visibility("default")))
> +#	define WEBKIT_OBSOLETE_API WEBKIT_API __attribute__((deprecated))
> +#endif

You should not indent preprocessor defines.