[webkit-reviews] review granted: [Bug 68434] [GTK] Implement cache model for WebKit2 : [Attachment 109934] Updated patch to use sysconf

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 68434: [GTK] Implement cache model for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68434

Attachment 109934: Updated patch to use sysconf
https://bugs.webkit.org/attachment.cgi?id=109934&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109934&action=review


Looks good, but please handle the situation where sysconf returns an error
before landing.

> Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:46
> +#else
> +static uint64_t kDefaultMemorySize = 512;
> +#endif

I would move this down to getMemorySize.

> Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:68
> +#if !OS(WINDOWS)
> +    return ((sysconf(_SC_PAGESIZE) / 1024) * sysconf(_SC_PHYS_PAGES)) /
1024;
> +#else
> +    // Fallback to default for other platforms.

If any of these sysconf calls return -1 you need to return the default memory
size.