[webkit-reviews] review denied: [Bug 64071] new-run-webkit-tests does not support qt-4.8 results : [Attachment 109951] updated fallback path

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 64071: new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Attachment 109951: updated fallback path
https://bugs.webkit.org/attachment.cgi?id=109951&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109951&action=review


In general LGTM, but please fix these little things.

> Tools/ChangeLog:9
> +	   * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Removed.

Removed ????

> Tools/Scripts/webkitpy/layout_tests/port/qt.py:93
> +    def qt_version(self):

@memoized is still missing

> Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py:59
> +	       return 'QMake version 2.01a\nUsing Qt version 4.8.0 in
/usr/local/Trolltech/Qt-4.8.2/lib'

one more s/4.8.2/4.8.0 :)