[webkit-reviews] review denied: [Bug 48459] Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows : [Attachment 109923] regenerate patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 6 06:19:03 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has denied  review:
Bug 48459: Glyphs in vertical text tests are rotated 90 degrees clockwise on
Windows
https://bugs.webkit.org/show_bug.cgi?id=48459

Attachment 109923: regenerate patch with test cases
https://bugs.webkit.org/attachment.cgi?id=109923&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
If you want your patch to be reviewed, you should mark it r?. If you want it to
be committed after it's reviewed, you should mark it cq?. I'll assume both of
those are true in this case and you just didn't know.

I think many of these tests have Windows-specific pixel results (the
*-expected.png files). They need to be regenerated too. You can get pixel
results to be generated by passing -p to run-webkit-tests.


More information about the webkit-reviews mailing list