[webkit-reviews] review granted: [Bug 69469] [GTK][V8] Add JSC compilation option to configure.ac : [Attachment 109869] Configure JSC or V8

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 69469: [GTK][V8] Add JSC compilation option to configure.ac
https://bugs.webkit.org/show_bug.cgi?id=69469

Attachment 109869: Configure JSC or V8
https://bugs.webkit.org/attachment.cgi?id=109869&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109869&action=review


Looks good, just one thing to fix before landing, thanks!

> GNUmakefile.am:199
> +if USE_JSC
> +global_cppflags += \
> +	-DWTF_USE_JSC=1
> +endif
> +

This define is not used yet, right? If not it should be introduced in the first
patch that will use it.