[webkit-reviews] review granted: [Bug 69301] WebFileChooserParams needs a value to specify a "Save As" dialog. : [Attachment 109544] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Bill Budge
<bbudge at gmail.com>'s request for review:
Bug 69301: WebFileChooserParams needs a value to specify a "Save As" dialog.
https://bugs.webkit.org/show_bug.cgi?id=69301

Attachment 109544: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=109544&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109544&action=review


> Source/WebKit/chromium/public/WebFileChooserParams.h:47
> +    bool saving;

I struggle a bit with the wording here.  I considered suggesting "saveAs". 
Then
at least you could say "saveAs" chooser, just as you can say "multiSelect"
chooser
or "directory" chooser.  I'm not sure though.

I feel like the properties here should either describe the dialog or the
resulting
file(s).  The other existing property names are not so great.

I can imagine something like
{return,select,choose}{Multiple,Directory,Writable}
might be nice.	Those would very clearly describe the file(s) being returned.

Anyways, maybe that's just fodder for a future patch as changes like that would

be pretty out-of-scope for what you are trying to do now.

I think there are still some details to work out about what it means to return
a writable file as a result of presenting a "save as" dialog.