[webkit-reviews] review denied: [Bug 69063] Forward fullscreenchanged event to plugins : [Attachment 109910] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied
polina at chromium.org's request for review:
Bug 69063: Forward fullscreenchanged event to plugins
https://bugs.webkit.org/show_bug.cgi?id=69063

Attachment 109910: Patch
https://bugs.webkit.org/attachment.cgi?id=109910&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109910&action=review


> Source/WebKit/chromium/public/WebPlugin.h:86
> +    virtual void onFullscreenChange() { }

nit: we normally use the convention of didSomeEvent or willDoSomeEvent instead
of onEvent.  that way the before/after relation is made clear.

we already have WebViewClient::{enter,exit}FullscreenForNode.  that is driven
from ChromeClient::{enter,exit}FullscreenForNode.
had you considered using that?