[webkit-reviews] review granted: [Bug 69298] Add an option to suppress rendering until the document's load event fires. : [Attachment 109865] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 69298: Add an option to suppress rendering until the document's load event
fires.
https://bugs.webkit.org/show_bug.cgi?id=69298

Attachment 109865: Patch
https://bugs.webkit.org/attachment.cgi?id=109865&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109865&action=review


> Source/WebCore/ChangeLog:16
> +	   No tests currently possible. Testing this would require the ability
for
> +	   DRT to dump state while resources are loading, which it doesn't
> +	   currently do.

Can't we use an http test that trickles in the main resource, and a pixel test
for this?

> Source/WebCore/rendering/RenderLayer.cpp:2629
> +    ASSERT_ARG(layer, layer);

This isn't much use. We'll crash on the next line if layer is null.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:250
> +    // Compositing layers will be updated in Document::implicitClose() if
suppressed here.
> +    if (!m_renderView->document()->visualUpdatesAllowed())
> +	   return;

This is a different throttling mechanism to that used elsewhere. See
LayerTreeHostCAMac::setLayerFlushSchedulingEnabled(). Maybe we should move that
logic down into WebCore. That can be done later though.