[webkit-reviews] review granted: [Bug 69492] [Mac] Should be able to scroll embedded PDFs from keyboard : [Attachment 109896] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 69492: [Mac] Should be able to scroll embedded PDFs from keyboard
https://bugs.webkit.org/show_bug.cgi?id=69492

Attachment 109896: proposed fix
https://bugs.webkit.org/attachment.cgi?id=109896&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109896&action=review


> Source/WebCore/rendering/RenderEmbeddedObject.cpp:259
> +    PluginViewBase* view = static_cast<PluginViewBase*>(widget());
> +    return view->scroll(direction, granularity);

I don’t think the local variable adds clarity.

> Source/WebCore/rendering/RenderEmbeddedObject.h:71
> +    virtual bool scroll(ScrollDirection, ScrollGranularity, float multiplier
= 1, Node** stopNode = 0);
> +    virtual bool logicalScroll(ScrollLogicalDirection, ScrollGranularity,
float multiplier = 1, Node** stopNode = 0);

Might not need the default values on these overrides.