[webkit-reviews] review granted: [Bug 69478] Add explicit JSGlobalThis type. : [Attachment 109879] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 16:57:57 PDT 2011

Darin Adler <darin at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 69478: Add explicit JSGlobalThis type.

Attachment 109879: The patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109879&action=review

> Source/JavaScriptCore/ChangeLog:8
> +
> +	   JSC supports a spilt global object, as used by WebCore for the
Window. As a stage

Typo: spilt

> Source/JavaScriptCore/runtime/JSGlobalObject.h:-171
> -	       putThisToAnonymousValue(0);

Patch won’t apply because Oliver just removed this in another patch.

More information about the webkit-reviews mailing list