[webkit-reviews] review denied: [Bug 69440] AccessibilityMenuList does not fire change notification when popup is not open. : [Attachment 109843] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 69440: AccessibilityMenuList does not fire change notification when popup
is not open.
https://bugs.webkit.org/show_bug.cgi?id=69440

Attachment 109843: Patch
https://bugs.webkit.org/attachment.cgi?id=109843&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109843&action=review


layout test needed. otherwise seems ok

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:96
> +	       popup->didUpdateActiveOption(optionIndex);

i think we should take this patch to verify (outside of ASSERT)  that
childObjects[0].get() actually is a AccessibilityMenuListPopup, by doing
something like if (childObjects[0]->isMenuListPopup())