[webkit-reviews] review granted: [Bug 69313] [flexbox] take marginBeforeForChild into account when positioning children : [Attachment 109570] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 69313: [flexbox] take marginBeforeForChild into account when positioning
children
https://bugs.webkit.org/show_bug.cgi?id=69313

Attachment 109570: Patch
https://bugs.webkit.org/attachment.cgi?id=109570&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109570&action=review


> LayoutTests/css3/flexbox/002.html:34
> +<div data-expected-height="120" class="flexbox">

Did you mean to add data-expected-height here?

> LayoutTests/css3/flexbox/002.html:35
> +  <div data-expected-width="200" data-offset-y="50" style="width:
-webkit-flex(1 0 0); margin: 50px 0;"></div>

Can we add a new test case rather than changing a test case?

> LayoutTests/css3/flexbox/writing-modes.html:78
> -  <div data-expected-height="150" data-offset-y="0" style="height:
-webkit-flex(1 0 0);"></div>
> +  <div data-expected-height="150" data-offset-y="0" data-offset-x="50"
style="height: -webkit-flex(1 0 0); margin: 0 100px 0 50px;"></div>

Ditto.

> LayoutTests/css3/flexbox/writing-modes.html:164
> -  <div data-expected-height="150" data-offset-y="0" data-offset-x="580"
style="height: -webkit-flex(1 0 0);"></div>
> +  <div data-expected-height="150" data-offset-y="0" data-offset-x="480"
style="height: -webkit-flex(1 0 0); margin: 0 100px 0 50px;"></div>

Ditto.

> LayoutTests/css3/flexbox/writing-modes.html:172
> -  <div data-expected-width="150" data-offset-y="180" data-offset-x="0"
style="width: -webkit-flex(1 0 0);"></div>
> +  <div data-expected-width="150" data-offset-y="130" data-offset-x="0"
style="width: -webkit-flex(1 0 0); margin: 100px 0 50px 0;"></div>

Ditto.