[webkit-reviews] review granted: [Bug 69390] JSC objects need to know their own cell size at runtime. : [Attachment 109855] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 13:56:24 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 69390: JSC objects need to know their own cell size at runtime.
https://bugs.webkit.org/show_bug.cgi?id=69390

Attachment 109855: Patch
https://bugs.webkit.org/attachment.cgi?id=109855&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109855&action=review


> Source/JavaScriptCore/runtime/JSObject.h:494
> +inline size_t JSCell::cellSize() const
> +{
> +    return classInfo()->cellSize;
> +}

This function is unused. I still think it can be inlined at the call site when
used.


More information about the webkit-reviews mailing list