[webkit-reviews] review denied: [Bug 69386] REGRESSION: Curious Location of StorageTracker.db : [Attachment 109853] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 69386: REGRESSION: Curious Location of StorageTracker.db
https://bugs.webkit.org/show_bug.cgi?id=69386

Attachment 109853: Patch
https://bugs.webkit.org/attachment.cgi?id=109853&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109853&action=review


> Source/WebKit/mac/Storage/WebStorageManager.mm:93
>      static NSString *sLocalStoragePath;

Is this code only ever running on main thread?

> Source/WebKit/mac/Storage/WebStorageManager.mm:98
>      NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];

I wonder why it's reading defaults every time, not just on initialization.

> Source/WebKit/mac/Storage/WebStorageManager.mm:105
> +    sLocalStoragePath = [[sLocalStoragePath stringByStandardizingPath]
retain];

This code will retain each time, but the function is not a "copy" one.