[webkit-reviews] review requested: [Bug 69455] Option.value should trim extra internal html spaces : [Attachment 109848] Patch fixing the space triming issue for value attribute.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 13:26:58 PDT 2011


Sachin Puranik <jcqt43 at motorola.com> has asked	for review:
Bug 69455: Option.value should trim extra internal html spaces
https://bugs.webkit.org/show_bug.cgi?id=69455

Attachment 109848: Patch fixing the space triming issue for value attribute.
https://bugs.webkit.org/attachment.cgi?id=109848&action=review

------- Additional Comments from Sachin Puranik <jcqt43 at motorola.com>
Hi,

1. Restructured the code as per comments in the bug #68684.
2. Fixed the internal space striping issue for option.value.
3. Added a test case.


One more question I have?

<select>
<option id="o1">Hello	   Spaces</option>
</select>
<script>
var o = document.getElementById('o3');
alert(o.value);
o.value="";
alert(o.value);
</script>

Now first alert will be "Hello Spaces".
But after setting a "" value to option.value , it always returns "". is this
correct behaviour. Now we can never go back to the original state and we will
never get the option.value as  "Hello Spaces". is this correct? I feel this is
inconsistent.


More information about the webkit-reviews mailing list