[webkit-reviews] review denied: [Bug 69451] Adding gamepad support : [Attachment 109841] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Scott Graham
<scottmg at chromium.org>'s request for review:
Bug 69451: Adding gamepad support
https://bugs.webkit.org/show_bug.cgi?id=69451

Attachment 109841: Patch
https://bugs.webkit.org/attachment.cgi?id=109841&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109841&action=review


> Source/WebKit/chromium/public/WebViewClient.h:303
> +    // Gamepad -------------------------------------------------------------


nit: new line after section divider.  please preserve the 2 new lines between
sections.

it seems like the concept of a gamepad really belongs more at the platform
layer of
webkit.  this seems like something you would get via the WebKitPlatformSupport
interface
instead of the WebViewClient.  i'd imagine that you probably need something to
be contextual
to the WebView however.  can you explain that part?  maybe we could meet up to
review this
in a little more detail?