[webkit-reviews] review granted: [Bug 69280] [WinCairo] Support a wincairo Skipped File : [Attachment 109735] Update old-build-webkit-tests to know about wincairo

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 69280: [WinCairo] Support a wincairo Skipped File
https://bugs.webkit.org/show_bug.cgi?id=69280

Attachment 109735: Update old-build-webkit-tests to know about wincairo
https://bugs.webkit.org/attachment.cgi?id=109735&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109735&action=review


> Tools/Scripts/old-run-webkit-tests:2479
> -
> + 

Might as well undo this.

> Tools/Scripts/webkitdirs.pm:238
>      if ($configuration && isWinCairo()) {
> -	   $configuration .= "_Cairo_CFLite";
> +	   unless ($configuration =~ /_Cairo_CFLite$/) {
> +	       $configuration .= "_Cairo_CFLite";
> +	   }
>      }

Was this always buggy? Why hadn't we run into it before?