[webkit-reviews] review denied: [Bug 69390] JSC objects need to know their own cell size at runtime. : [Attachment 109834] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 69390: JSC objects need to know their own cell size at runtime.
https://bugs.webkit.org/show_bug.cgi?id=69390

Attachment 109834: Patch
https://bugs.webkit.org/attachment.cgi?id=109834&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109834&action=review


> Source/JavaScriptCore/runtime/WriteBarrier.h:50
> +    ASSERT(WTF::RemovePointer<T>::Type::s_info.cellSize == sizeof(typename
WTF::RemovePointer<T>::Type));

This isn't a safe assertion

class A {
 ...
}

class B : A {
  int aNewField;
}

validateCell<A*>(&someB)

would fail this assertion as B's classinfo will (correctly) report a larger
cell size than A's.