[webkit-reviews] review requested: [Bug 68099] [V8] Null v8::Context crash in V8DOMWindowShell::namedItemAdded() : [Attachment 109819] missed a case in CodeGeneratorV8.pm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 10:33:07 PDT 2011


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 68099: [V8] Null v8::Context crash in V8DOMWindowShell::namedItemAdded()
https://bugs.webkit.org/show_bug.cgi?id=68099

Attachment 109819: missed a case in CodeGeneratorV8.pm
https://bugs.webkit.org/attachment.cgi?id=109819&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
The case in CodeGeneratorV8.pm apparently depended on initContextIfNeeded()
returning false if a context already existed. Just checking for a context
before calling initContextIfNeeded() should be sufficient in that case.


More information about the webkit-reviews mailing list