[webkit-reviews] review granted: [Bug 68684] spec change - option.label should be reflected like option.value : [Attachment 109770] Fixed the layout test error.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sachin Puranik
<jcqt43 at motorola.com>'s request for review:
Bug 68684: spec change - option.label should be reflected like option.value
https://bugs.webkit.org/show_bug.cgi?id=68684

Attachment 109770: Fixed the layout test error.
https://bugs.webkit.org/attachment.cgi?id=109770&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109770&action=review


> Source/WebCore/html/HTMLOptionElement.cpp:228
> +    label = collectOptionInnerText(this).stripWhiteSpace(isHTMLSpace);
> +    label = label.simplifyWhiteSpace(isHTMLSpace);
> +
> +    return label;

I think this would read better without the local variable:

    return
collectOptionInnerText(this).stripWhiteSpace(isHTMLSpace).simplifyWhiteSpace(is
HTMLSpace);