[webkit-reviews] review granted: [Bug 69274] [Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView : [Attachment 109503] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 69274: [Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=69274

Attachment 109503: Patch
https://bugs.webkit.org/attachment.cgi?id=109503&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109503&action=review


LGTM!

> Source/WebKit2/ChangeLog:15
> +	   empty and null strings.

between* empty and null strings

> Source/WebKit2/UIProcess/qt/ClientImpl.cpp:148
> +void qt_wk_runJavaScriptAlert(WKPageRef page, WKStringRef alertText,
WKFrameRef frame, const void *clientInfo)

Style, * placement.

> Source/WebKit2/UIProcess/qt/ClientImpl.cpp:154
> +bool qt_wk_runJavaScriptConfirm(WKPageRef, WKStringRef message, WKFrameRef,
const void *clientInfo)

Ditto.

> Source/WebKit2/UIProcess/qt/ClientImpl.cpp:160
> +static inline WKStringRef createNullWKString()

C API candidate? Maybe not.

> Source/WebKit2/UIProcess/qt/ClientImpl.cpp:166
> +WKStringRef qt_wk_runJavaScriptPrompt(WKPageRef, WKStringRef message,
WKStringRef defaultValue, WKFrameRef, const void *clientInfo)

Style, * placement.

> Source/WebKit2/UIProcess/qt/ClientImpl.h:44
> +void qt_wk_runJavaScriptAlert(WKPageRef, WKStringRef alertText, WKFrameRef,
const void *clientInfo);
> +bool qt_wk_runJavaScriptConfirm(WKPageRef, WKStringRef message, WKFrameRef,
const void *clientInfo);
> +WKStringRef qt_wk_runJavaScriptPrompt(WKPageRef, WKStringRef message,
WKStringRef defaultValue, WKFrameRef, const void *clientInfo);

Ditto.