[webkit-reviews] review granted: [Bug 69424] REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces : [Attachment 109803] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 69424: REGRESSION (r96595): WTFReportBacktrace listed as the top frame in
all assertion backtraces
https://bugs.webkit.org/show_bug.cgi?id=69424

Attachment 109803: Patch
https://bugs.webkit.org/attachment.cgi?id=109803&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109803&action=review


> Source/JavaScriptCore/wtf/Assertions.cpp:199
> +    static const int maxFrames = 31;
> +    static const int skipFrames = 2;
> +    void* samples[maxFrames + skipFrames];
> +    int frames = maxFrames + skipFrames;

I don't think the name maxFrames is so great anymore. We request more than
maxFrames, after all. I'd suggest calling the two constants framesToShow and
framesToSkip.

Other than that this all looks good.