[webkit-reviews] review denied: [Bug 69424] REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces : [Attachment 109795] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 69424: REGRESSION (r96595): WTFReportBacktrace listed as the top frame in
all assertion backtraces
https://bugs.webkit.org/show_bug.cgi?id=69424

Attachment 109795: Patch
https://bugs.webkit.org/attachment.cgi?id=109795&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109795&action=review


> Source/JavaScriptCore/wtf/Assertions.cpp:172
>      *size = backtrace(stack, *size);

We need to support skipFrames here, too. (If we can't implement skipFrames in
WTFGetBacktrace on all ports, perhaps WTFReportBacktrace should just do the
skipping on its own.)

> Source/JavaScriptCore/wtf/Assertions.cpp:202
> +    WTFGetBacktrace(samples, &frames, 2);
>  
>      for (int i = 1; i < frames; ++i) {

This doesn't seem right. We tell WTFGetBacktrace to skip two frames, but then
we skip a third frame when starting the loop.