[webkit-reviews] review requested: [Bug 65769] New renderer for SVGRectElement : [Attachment 109781] Propsed patch

[bugzilla-daemon at webkit.org]

Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 65769: New renderer for SVGRectElement
https://bugs.webkit.org/show_bug.cgi?id=65769

Attachment 109781: Propsed patch
https://bugs.webkit.org/attachment.cgi?id=109781&action=review

------- Additional Comments from Renata Hodovan <reni at webkit.org>
> Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:268
> +	       if (path)
> +		   context->fillPath(*path);
> +	       else if (shape)
> +		   shape->fillShape(context);

I guess at some point, we want to stop passing const Path* path to
postApplyResource completly and only pass/use the RenderSVGShape object right?
This currently looks a bit weird. Maybe a FIXME would clarify it.

We need to pass const Path* to postApplyResource() because it's called from
SVGTextRunRenderingContext::drawSVGGlyphs() as well which is not inherited from
RenderSVGShape(). So it needs to get the path value from the parameter list.

@krit: Sorry about the dead codes, I missed to delete them after the usage of
the different bounding boxes was clarified. I runned layout tests with this
version, so deleting the comments won't cause any regressions (btw I tested it
again).

All the other propsals are fulfilled.