[webkit-reviews] review granted: [Bug 64263] libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed : [Attachment 109401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 02:25:34 PDT 2011

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 64263: libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL'

Attachment 109401: Patch

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109401&action=review

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:-708
> -    if (d->m_finished || soupMessage->status_code == SOUP_STATUS_NONE)

It's not immediately obvious why it's OK to remove the status_code check, so
please add a comment in the ChangeLog about it.

More information about the webkit-reviews mailing list