[webkit-reviews] review denied: [Bug 69351] Web Inspector: make ResourceView(s) compile : [Attachment 109655] [Patch] More ResourceViews.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 01:56:17 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 69351: Web Inspector: make ResourceView(s) compile
https://bugs.webkit.org/show_bug.cgi?id=69351

Attachment 109655: [Patch] More ResourceViews.
https://bugs.webkit.org/attachment.cgi?id=109655&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109655&action=review


> Source/WebCore/inspector/front-end/ResourceHeadersView.js:328
> +	   if (typeof headersLength === "number") {

Extract all this block into a separate method and call it explicitly where
needed instead of doing this odd check here.


More information about the webkit-reviews mailing list