[webkit-reviews] review granted: [Bug 69402] Input styles are unexpectedly shared regardless of required status difference. : [Attachment 109751] Patch

Wed Oct 5 00:59:25 PDT 2011

Daniel Bates <dbates at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 69402: Input styles are unexpectedly shared regardless of required status
difference.
https://bugs.webkit.org/show_bug.cgi?id=69402

Attachment 109751: Patch
https://bugs.webkit.org/attachment.cgi?id=109751&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109751&action=review

This patch looks straightforward. I have some minor nits.

> LayoutTests/fast/css/pseudo-required-shared-expected.html:4
> +<input value=required style="color:red;">
> +<input value=optional>

Nit: For consistency with the style attribute, I suggest surrounding all
attribute values with quotes:

<input value="required" style="color:red">
<input value="optional">

> LayoutTests/fast/css/pseudo-required-shared.html:2
> +<!DOCTYPE html>
> +<!-- There was a bug that styles are unexpectedly shared regardless of
required status difference. -->

This isn't a valid HTML5 document as per section 8.1.2.4
<http://dev.w3.org/html5/spec/Overview.html#optional-tags> which states that
"An html element's start tag may be omitted if the first thing inside the html
element is not a comment.". That is, we need an <html> tag here since the first
thing is a comment.

For you consideration, you may want to make the markup closer resemble the form
of a basic HTML document as described in section 1.8 of the HTML5 spec.
<http://dev.w3.org/html5/spec/Overview.html#a-quick-introduction-to-html>.

> LayoutTests/fast/css/pseudo-required-shared.html:7
> +

Nit: Please remove this empty line as it doesn't seem to improve the
readability of this markup given that we have exactly one CSS block.

> LayoutTests/fast/css/pseudo-required-shared.html:11
> +<input required value=required>
> +<input value=optional>

Nit: I suggest surrounding attribute values in quotes so as to demarcate them
from the rest of the markup.