[webkit-reviews] review denied: [Bug 69146] Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances. : [Attachment 109639] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 69146: Web Inspector: debuggerPresentatioModel.linkifyLocation leaks
updateAnchor closure instances.
https://bugs.webkit.org/show_bug.cgi?id=69146

Attachment 109639: Patch
https://bugs.webkit.org/attachment.cgi?id=109639&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109639&action=review


Overall looks good. Could you update it and let Pavel P. take a look?

> LayoutTests/inspector/debugger/linkifier.html:21
> +	   DummyPresentationModel = function()

You should define classes according the the style guidelines.

> LayoutTests/inspector/debugger/linkifier.html:25
> +		   this.addEventListener = function(eventName, callback,
object)

ditto

> LayoutTests/inspector/debugger/linkifier.html:37
> +	   DummyPresentationModel.prototype = {

ditto

> Source/WebCore/inspector/front-end/ConsoleView.js:701
> +    WebInspector.ConsoleCommandResult = function(result, wasThrown,
originatingCommand, linkifier)

Weird space added. It is clear that it has been added, not removed.