[webkit-reviews] review denied: [Bug 69396] In WebKitTestRunner, text has font smoothing in pixel snapshots : [Attachment 109743] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 4 21:39:36 PDT 2011
mitz at webkit.org has denied Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 69396: In WebKitTestRunner, text has font smoothing in pixel snapshots
https://bugs.webkit.org/show_bug.cgi?id=69396
Attachment 109743: Patch
https://bugs.webkit.org/attachment.cgi?id=109743&action=review
------- Additional Comments from mitz at webkit.org
WebKit preferences should not be used to set globals. Unfortunately on the
Windows port, this preference already has this incorrect behavior. Moving
forward, we need to deprecate it (which is easy since it’s in a private
header), not add incorrect implementations on other platforms.
More information about the webkit-reviews
mailing list