[webkit-reviews] review requested: [Bug 69220] Fix FrameView::scrollElementToRect to take already scrolled amount into consideration : [Attachment 109723] setScrollPosition
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 4 17:33:51 PDT 2011
sadrul at chromium.org has asked for review:
Bug 69220: Fix FrameView::scrollElementToRect to take already scrolled amount
into consideration
https://bugs.webkit.org/show_bug.cgi?id=69220
Attachment 109723: setScrollPosition
https://bugs.webkit.org/attachment.cgi?id=109723&action=review
------- Additional Comments from sadrul at chromium.org
ScrollView::scrollTo has a NOTE saying it should only be called by the
overriden setScrollOffset from ScrollableArea, and FrameView::scrollToAnchor
has a comment saying it can trigger setScrollPosition. So I have changed here
to use setScrollPosition instead of scrollTo/scrollBy. Does this look OK?
More information about the webkit-reviews
mailing list