[webkit-reviews] review requested: [Bug 69322] DFG should be capable of a broader range of speculations on branch and not : [Attachment 109721] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 4 17:15:39 PDT 2011
Filip Pizlo <fpizlo at apple.com> has asked for review:
Bug 69322: DFG should be capable of a broader range of speculations on branch
and not
https://bugs.webkit.org/show_bug.cgi?id=69322
Attachment 109721: the patch
https://bugs.webkit.org/attachment.cgi?id=109721&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Updated performance after merging.
Benchmark report for SunSpider, V8, and Kraken.
VMs tested:
"TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc
"BetterBranch" at
/Volumes/Data/pizlo/septenary/OpenSource/WebKitBuild/Release/jsc
Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark.
Used 1 benchmark iteration per VM
invocation for warm-up. Used the jsc-specific preciseTime() function to get
microsecond-level timing. Reporting
benchmark execution times with 95% confidence intervals in milliseconds.
TipOfTree BetterBranch
SunSpider:
3d-cube 7.4812+-0.1460 ?
7.5067+-0.1737 ?
3d-morph 7.3919+-0.1335
7.3708+-0.1453
3d-raytrace 7.5996+-0.1626 ?
7.7081+-0.1909 ? might be 1.0143x slower
access-binary-trees 1.7566+-0.0562
1.7154+-0.0455 might be 1.0240x faster
access-fannkuch 6.3631+-0.0820 ?
6.3847+-0.1062 ?
access-nbody 3.6076+-0.0756
3.5630+-0.0802 might be 1.0125x faster
access-nsieve 2.7525+-0.1543
2.5887+-0.0714 might be 1.0633x faster
bitops-3bit-bits-in-byte 1.7318+-0.0244
1.7168+-0.0479
bitops-bits-in-byte 2.7818+-0.0539
2.7355+-0.0740 might be 1.0169x faster
bitops-bitwise-and 3.4696+-0.0807 ?
3.9148+-0.5005 ? might be 1.1283x slower
bitops-nsieve-bits 5.4481+-0.0925
5.4103+-0.1025
controlflow-recursive 2.0624+-0.0400
2.0529+-0.0372
crypto-aes 6.4679+-0.1676 ?
6.5114+-0.1765 ?
crypto-md5 2.7490+-0.0700 ?
2.8099+-0.0835 ? might be 1.0222x slower
crypto-sha1 2.4743+-0.0590
2.4562+-0.0486
date-format-tofte 10.1093+-0.2269
9.8557+-0.1560 might be 1.0257x faster
date-format-xparb 9.5077+-0.2055
9.2729+-0.1515 might be 1.0253x faster
math-cordic 6.3826+-0.1270
6.3111+-0.1125 might be 1.0113x faster
math-partial-sums 7.6905+-0.1866
7.4815+-0.1294 might be 1.0279x faster
math-spectral-norm 2.7907+-0.0630 ?
2.8314+-0.0866 ? might be 1.0146x slower
regexp-dna 10.7219+-0.2144
10.7126+-0.1027
string-base64 5.5707+-0.1089
5.4329+-0.0964 might be 1.0254x faster
string-fasta 6.5750+-0.1426 ?
6.6665+-0.1379 ? might be 1.0139x slower
string-tagcloud 11.6204+-0.1419 ?
11.8170+-0.1822 ? might be 1.0169x slower
string-unpack-code 21.1400+-0.3545
20.9919+-0.2841
string-validate-input 6.2364+-0.1875 ?
6.2398+-0.1595 ?
<arithmetic> * 6.2493+-0.0159
6.2330+-0.0383
<geometric> 5.1367+-0.0177
5.1242+-0.0332
<harmonic> 4.2210+-0.0260
4.2030+-0.0362
TipOfTree BetterBranch
V8:
crypto 72.8145+-0.5199
72.6473+-0.4037
deltablue 214.1124+-1.0016 !
217.9888+-1.8622 ! definitely 1.0181x slower
earley-boyer 88.2514+-0.5703 ^
87.2301+-0.2962 ^ definitely 1.0117x faster
raytrace 62.1892+-0.5513 ^
58.1012+-0.4594 ^ definitely 1.0704x faster
regexp 102.9545+-0.5633 ?
104.1702+-0.7198 ? might be 1.0118x slower
richards 187.3573+-0.4727 ?
188.5787+-0.8794 ?
splay 90.9779+-0.8013
90.6149+-1.0160
<arithmetic> 116.9510+-0.1704 ?
117.0473+-0.2610 ?
<geometric> * 105.9743+-0.1602 ^
105.2228+-0.1759 ^ definitely 1.0071x faster
<harmonic> 97.4046+-0.1800 ^
95.9244+-0.2019 ^ definitely 1.0154x faster
TipOfTree BetterBranch
Kraken:
ai-astar 495.4805+-2.3816 !
502.2475+-3.9661 ! definitely 1.0137x slower
audio-beat-detection 190.5182+-0.9920 ?
191.6489+-1.1051 ?
audio-dft 270.7026+-2.4880
269.3619+-3.1474
audio-fft 125.9513+-0.6101 ?
126.4527+-0.9342 ?
audio-oscillator 247.7809+-1.8248
247.3469+-1.9099
imaging-darkroom 427.8471+-7.5061
426.0058+-2.2012
imaging-desaturate 225.0271+-1.6814 !
232.7494+-1.0558 ! definitely 1.0343x slower
imaging-gaussian-blur 585.0237+-2.6857
583.4547+-3.3415
json-parse-financial 49.2309+-0.2701 ^
48.5261+-0.4178 ^ definitely 1.0145x faster
json-stringify-tinderbox 68.9585+-0.7374 ?
70.1904+-1.0000 ? might be 1.0179x slower
stanford-crypto-aes 130.2263+-1.5949 ?
132.4506+-1.9081 ? might be 1.0171x slower
stanford-crypto-ccm 100.7143+-0.7437 !
103.0105+-1.1431 ! definitely 1.0228x slower
stanford-crypto-pbkdf2 190.2549+-1.9168 ?
190.8994+-2.4199 ?
stanford-crypto-sha256-iterative 76.2882+-1.1701
75.8700+-1.1122
<arithmetic> * 227.4289+-0.7199 ?
228.5868+-0.4489 ?
<geometric> 176.7279+-0.5544 !
177.7903+-0.3950 ! definitely 1.0060x slower
<harmonic> 136.9439+-0.4958 ?
137.5425+-0.4616 ?
TipOfTree BetterBranch
All benchmarks:
<arithmetic> 88.6201+-0.2244 !
88.9703+-0.1221 ! definitely 1.0040x slower
<geometric> 23.1301+-0.0572
23.1154+-0.0733
<harmonic> 7.4206+-0.0446
7.3890+-0.0619
TipOfTree BetterBranch
Geomean of preferred means:
<scaled-result> 53.2057+-0.0926
53.1228+-0.0961
More information about the webkit-reviews
mailing list