[webkit-reviews] review denied: [Bug 61344] --webkit-visual-word does not work in multi-line : [Attachment 107738] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 61344: --webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Attachment 107738: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=107738&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107738&action=review


> Source/WebCore/ChangeLog:10
> +	   DOM node.

Nit: it seems like DOM node fits in the previous line.

> Source/WebCore/editing/visible_units.cpp:1485
> +	   Position pos;
> +	   pos = createLegacyEditingPosition(previousNode,
caretMaxOffset(previousNode));

Nit: this should be don in one line.

> Source/WebCore/editing/visible_units.cpp:1487
> +	   if (pos.isCandidate()) {

Why do we need to check that this is a candidate?

> Source/WebCore/editing/visible_units.cpp:1493
> +	       InlineBox* boxInPreviousNode;
> +	       int ignoredCaretOffset;
> +	       pos.getInlineBoxAndOffset(DOWNSTREAM, boxInPreviousNode,
ignoredCaretOffset);
> +
> +	       if (boxInPreviousNode)
> +		   return boxInPreviousNode->root();

Please use RenderedPosition.

> Source/WebCore/editing/visible_units.cpp:1539
> +							    
nextRootInlineBox(box); 

Nit: wrong indentation.