[webkit-reviews] review denied: [Bug 67941] occasional crash in Chromium in dispatching keyEvent : [Attachment 109681] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 4 14:22:55 PDT 2011
Tony Chang <tony at chromium.org> has denied Scott Graham <scottmg at chromium.org>'s
request for review:
Bug 67941: occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941
Attachment 109681: Patch
https://bugs.webkit.org/attachment.cgi?id=109681&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109681&action=review
> LayoutTests/fast/events/keyevent-iframe-removed-crash.html:1
> +<script>
Nit: <!DOCTYPE html>
<html>
> LayoutTests/fast/events/keyevent-iframe-removed-crash.html:29
> +<body onload="go()">
> + PASS
> +</body>
Nit: Please add some text on how to run manually (press any key) and say the
test passes if it does not crash.
> LayoutTests/fast/events/keyevent-iframe-removed-crash.html:30
> +
Nit: </html>
More information about the webkit-reviews
mailing list