[webkit-reviews] review requested: [Bug 69321] JITCodeGenerator should no longer have code that tries too hard to be both speculative and non-speculative : [Attachment 109676] the patch - address some of review

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 69321: JITCodeGenerator should no longer have code that tries too hard to
be both speculative and non-speculative
https://bugs.webkit.org/show_bug.cgi?id=69321

Attachment 109676: the patch - address some of review
https://bugs.webkit.org/attachment.cgi?id=109676&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
The goal of this patch is to remove m_isSpeculative and speculationCheck() from
JITCodeGenerator, since neither of those members belong there now that we don't
have a non-speculative DFG JIT.  To do that, it moves emitBranch() to
SpeculativeJIT, and does not change it other than obvious clean-ups (like when
you remove m_isSpeculative and assume that it's always true then some control
flow changes).