[webkit-reviews] review granted: [Bug 69264] IndexedDB: Remove SQLite-LevelDB migration code : [Attachment 109491] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 13:31:08 PDT 2011


Tony Chang <tony at chromium.org> has granted Hans Wennborg <hans at chromium.org>'s
request for review:
Bug 69264: IndexedDB: Remove SQLite-LevelDB migration code
https://bugs.webkit.org/show_bug.cgi?id=69264

Attachment 109491: Patch
https://bugs.webkit.org/attachment.cgi?id=109491&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
I'm skeptical, but if you say so.  What if there's a user who hasn't run
chromium for the past 6 months?

Historically, we keep migration code forever.  For example, the history
database format has changed many times, but we still have all the migration
code in handle formats that are 3+ years old.

Is there a large benefit to removing the migration code?  Certainly code for
writing to sqlite can be removed, but that seems orthogonal to the migration
code.


More information about the webkit-reviews mailing list