[webkit-reviews] review denied: [Bug 69015] Web Inspector: Add support for search in script content. : [Attachment 109659] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 13:09:00 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 69015: Web Inspector: Add support for search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015

Attachment 109659: Patch
https://bugs.webkit.org/attachment.cgi?id=109659&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #26)
> > We don't use pointers to get values out of a function. Please use a
reference instead. r- because of this.
> 
> That's the way communication between frontend and backend is implemented in
Inspector.

That seems wrong. Why can't we use refenrece?


More information about the webkit-reviews mailing list