[webkit-reviews] review denied: [Bug 69342] force gray-aa if we must disable LCD due to drawing in a layer : [Attachment 109627] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Mike Reed <reed at google.com>'s
request for review:
Bug 69342: force gray-aa if we must disable LCD due to drawing in a layer
https://bugs.webkit.org/show_bug.cgi?id=69342

Attachment 109627: Patch
https://bugs.webkit.org/attachment.cgi?id=109627&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109627&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests. existing tests apply

This is just a lie - we don't have any layout tests that detect this change in
behavior (which is why it's been broken so often over the past few weeks).
Ideally we'd have tests - but if you can't come up with a way to add them, at
least be honest in the ChangeLog.

I really think we do need an automated way to test this - be it layout tests or
browser tests or something else.  The current situation is we break it all the
time and don't know until users complain.