[webkit-reviews] review denied: [Bug 69356] Move font-fixup code in WebKitTestRunner to a better place : [Attachment 109656] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 11:28:47 PDT 2011


Sam Weinig <sam at webkit.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 69356: Move font-fixup code in WebKitTestRunner to a better place
https://bugs.webkit.org/show_bug.cgi?id=69356

Attachment 109656: Patch
https://bugs.webkit.org/attachment.cgi?id=109656&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109656&action=review


> Tools/WebKitTestRunner/InjectedBundle/ActivateFonts.h:31
>  
> -void activateFonts();
> +void adjustFonts();

This should stay named activateFonts, because otherwise you will break everyone
else.


More information about the webkit-reviews mailing list