[webkit-reviews] review granted: [Bug 69009] Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false : [Attachment 109515] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 69009: Code clean-up: Make RenderObject::absoluteBoundingBoxRect and
associated methods const and make its parameter useTransforms no longer default
to false
https://bugs.webkit.org/show_bug.cgi?id=69009

Attachment 109515: Patch
https://bugs.webkit.org/attachment.cgi?id=109515&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109515&action=review


Doesn’t seem like a big improvements, but seems OK.

> Source/WebCore/html/shadow/SliderThumbElement.cpp:43
> +#include "RenderObject.h"

This include is should not be added. RenderDeprecatedFlexibleBox.h already
includes it, and if we did need to include something it would be farther down
the inheritance tree than RenderObject.h.

> Source/WebCore/html/shadow/SliderThumbElement.cpp:220
> +    // FIXME: this should probably respect transforms 

Format of this comment is not right. We use sentence style where the first
letter is capitalized and a period ends the sentence.

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:41
> +#include "RenderObject.h"

This include is should not be added. RenderTextControlSingleLine.h already
includes it, and if we did need to include something it would be farther down
the inheritance tree than RenderObject.h.

> Source/WebCore/rendering/RenderFileUploadControl.cpp:135
> +	   // FIXME: make this work with transforms.

Again, wrong format.