[webkit-reviews] review granted: [Bug 67592] Take pageScaleFactor into account for MouseRelatedEvents. : [Attachment 108494] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 11:15:39 PDT 2011

Simon Fraser (smfr) <simon.fraser at apple.com> has granted John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 67592: Take pageScaleFactor into account for MouseRelatedEvents.

Attachment 108494: Patch

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108494&action=review

> LayoutTests/fast/events/script-tests/page-scaled-mouse-click-iframe.js:35
> +	   debug("This test requires DumpRenderTree.  Click on the blue rect
with the left mouse button to log the mouse coordinates.")

... or WebKitTestRunner.

> Source/WebCore/dom/MouseRelatedEvent.cpp:53
> +    return LayoutSize(frameView->scrollX() / scaleFactor,
> +	   frameView->scrollY() / scaleFactor);

You should unwrap this line.

More information about the webkit-reviews mailing list