[webkit-reviews] review granted: [Bug 69349] garden-o-matic doesn't launch its UI on Lion : [Attachment 109643] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 69349: garden-o-matic doesn't launch its UI on Lion
https://bugs.webkit.org/show_bug.cgi?id=69349

Attachment 109643: Patch
https://bugs.webkit.org/attachment.cgi?id=109643&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109643&action=review


> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:92
> +	   return 'file://' +
os.path.join(GardeningHTTPRequestHandler.STATIC_FILE_DIRECTORY,
'garden-o-matic.html')

Strictly speaking, prepending "file://" does not make a file URL. It would be
better if there was a function that did the necessary escaping as well.