[webkit-reviews] review granted: [Bug 68959] Extend DOM WheelEvent to differentiate between physical and logical scroll directions : [Attachment 109510] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 68959: Extend DOM WheelEvent to differentiate between physical and logical
scroll directions
https://bugs.webkit.org/show_bug.cgi?id=68959

Attachment 109510: Patch
https://bugs.webkit.org/attachment.cgi?id=109510&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109510&action=review


> Source/WebKit2/ChangeLog:41
> +2011-09-28  Jon Lee	<jonlee at apple.com>
> +
> +	   Extend DOM WheelEvent to differentiate between physical and logical
scroll directions
> +	   https://bugs.webkit.org/show_bug.cgi?id=68959
> +	   <rdar://problem/10036688>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Shared/WebEvent.h:
> +	   (WebKit::WebWheelEvent::directionInvertedFromDevice):
> +	   * Shared/WebEventConversion.cpp:
> +	   (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
> +	   * Shared/WebWheelEvent.cpp:
> +	   (WebKit::WebWheelEvent::WebWheelEvent):
> +	   (WebKit::WebWheelEvent::encode):
> +	   (WebKit::WebWheelEvent::decode):
> +	   * Shared/mac/WebEventFactory.mm:
> +	   (WebKit::WebEventFactory::createWebWheelEvent): get the flag from
the NSEvent.
> +	   * UIProcess/WebPageProxy.cpp:
> +	   (WebKit::coalesce):

Double changelog!