[webkit-reviews] review requested: [Bug 69166] Inset focus ring (Skia on Mac) : [Attachment 109338] Patch

[bugzilla-daemon at webkit.org]

Cary Clark <caryclark at google.com> has asked  for review:
Bug 69166: Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166

Attachment 109338: Patch
https://bugs.webkit.org/attachment.cgi?id=109338&action=review

------- Additional Comments from Cary Clark <caryclark at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109338&action=review


>>> Source/WebCore/ChangeLog:13
>>> +	     No new tests. This platform is not enabled.
>> 
>> Nit:  It would be nice to know which tests will exercise this when the
platform is enabled (if any).
> 
> I don't understand this comment.  This patch effects the Chromium Mac Skia
build, which you've asked the WebKit gardener (i.e., me) to maintain.  In any
case, I'll give you an exact list of the tests it effects in a few minutes.

The comment at the time was a misunderstanding on my part. I thought the
platform was disabled, and that WebKit gardening was unaffected. I was wrong.
Now test_expectations has been checked in that makes this disabled for real. I
apologize again for the earlier confusion.